Skip to content

diagnostic: add warning on upcoming glibc 2.39#21616

Merged
MikeMcQuaid merged 4 commits intomainfrom
brew-doctor-glibc-2.39
Feb 26, 2026
Merged

diagnostic: add warning on upcoming glibc 2.39#21616
MikeMcQuaid merged 4 commits intomainfrom
brew-doctor-glibc-2.39

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Feb 23, 2026 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?
  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

Based on check_glibc_version but no tier change and some wording difference in first paragraph.

Currently looks like:

$ brew doctor
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Your system glibc 2.35 is older than the next CI version.
An upcoming brew release will automatically install a newer version.

We recommend updating to a newer version via your distribution's
package manager, upgrading your distribution to the latest version,
or changing distributions.

Copilot AI review requested due to automatic review settings February 23, 2026 19:43
Copilot AI reviewed Feb 23, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a diagnostic warning to notify users when their system glibc version (2.35 ≤ version < 2.39) will be affected by an upcoming CI migration to glibc 2.39. The warning is implemented by setting LINUX_GLIBC_NEXT_CI_VERSION to "2.39" and adding a new diagnostic check method check_glibc_next_version that displays a user-friendly warning message without triggering a tier change.

Changes:

  • Added a comment to LINUX_GLIBC_NEXT_CI_VERSION constant explaining that setting it activates user notifications
  • Implemented check_glibc_next_version diagnostic method that warns users with glibc versions between the current CI version (2.35) and next CI version (2.39)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
Library/Homebrew/os.rb Added inline comment to LINUX_GLIBC_NEXT_CI_VERSION constant explaining its purpose as a notification trigger
Library/Homebrew/extend/os/linux/diagnostic.rb Added new check_glibc_next_version method to display warning for glibc versions between 2.35 and 2.39

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cho-m cho-m marked this pull request as draft February 23, 2026 19:50
cho-m
cho-m commented Feb 23, 2026
View reviewed changes
@cho-m cho-m mentioned this pull request Feb 23, 2026
Merged
6 tasks
@cho-m cho-m force-pushed the brew-doctor-glibc-2.39 branch 3 times, most recently from 4cf9021 to 9bca7be Compare February 23, 2026 20:53
@cho-m cho-m marked this pull request as ready for review February 23, 2026 21:02
@cho-m cho-m force-pushed the brew-doctor-glibc-2.39 branch from 9bca7be to 009fd31 Compare February 23, 2026 21:05
@cho-m cho-m force-pushed the brew-doctor-glibc-2.39 branch from 009fd31 to fae95de Compare February 23, 2026 21:13
@cho-m cho-m mentioned this pull request Feb 23, 2026
Draft
MikeMcQuaid
MikeMcQuaid approved these changes Feb 24, 2026
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Some suggestions.

cho-m and others added 3 commits February 25, 2026 11:54
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Feb 26, 2026
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Feb 26, 2026

Thanks @cho-m!

Merged via the queue into main with commit 1fc1012 Feb 26, 2026
37 checks passed
@MikeMcQuaid MikeMcQuaid deleted the brew-doctor-glibc-2.39 branch February 26, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cho-m @MikeMcQuaid