cmd/shellenv: more shell detection fixes. #21390
Merged
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relying on `SHELL` is not reliable enough to detect e.g. `fish` given how some of our users do it. Let's fall back to using `ps` and instead add a fallback for sandboxes.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves shell detection in the shellenv command by prioritizing the parent process name (obtained via ps) over the SHELL environment variable, while maintaining a fallback for sandboxed environments where ps may not work.
Changes:
- Implements a three-tier shell detection strategy: explicit parameter → parent process name via
ps→SHELLenvironment variable - Adds comments explaining each detection method and its limitations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rylan12
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relying on
SHELLis not reliable enough to detect e.g.fishgiven how some of our users do it.Let's fall back to using
psand instead add a fallback for sandboxes.@maschwenk @bolinfest The needs of Fish, the macOS sandbox and e.g. Cursor here contradict so we're going to move back to the original
psmethod that has worked well for years. If that's not working for you, hopefully the fallback here will work or you can just use e.g.brew shellenv zshto bypass it all (and speed it up at little).Fixes #21388
Fixes Homebrew/install#1069
Fixes #21382
See also #21157, #21284, #21374