cmd/tap-info: revert exit code changes to --json only
#21370
Merged
+1
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts exit code behavior changes for the --json mode of brew tap-info, addressing regressions in downstream tools. The JSON mode now always returns a success exit code (0) regardless of tap installation status, while the non-JSON mode continues to return a failure exit code (1) for uninstalled taps.
- Removes
Homebrew.failed = truecheck fromprint_tap_jsonmethod - Simplifies the JSON generation code from explicit iteration to a concise
map(&:to_hash)call - Maintains existing behavior for non-JSON mode where uninstalled taps trigger failure exit codes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
p-linnane
approved these changes
Jan 7, 2026
MikeMcQuaid
approved these changes
Jan 7, 2026
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Makes sense for JSON case, agreed, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21310 presented a good case for returning an exit code on
brew tap-infohowever this shouldn't apply to--jsonfor multiple reasons:brew tap-info,brew tap-info --jsonis designed to work on uninstalled core taps (i.e. from the API).brew tap-info --jsonis able to provide install locations even when taps aren't installed.installedin the JSONThis fixes regressions seen downstream (public example: rcmdnk/homebrew-file#373).
The case originally presented in #21301 is still retained since that talked about the non-JSON case.