Exit with failure on tap-info for unknown tap #21310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements failure exit behavior for the tap-info command when querying information about taps that are not installed, ensuring the command returns a non-zero exit code in such cases.
Key changes:
- Added
Homebrew.failed = truewhen a tap is not installed in the text output path - Added a test case to verify that
tap-infofails for unknown taps
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Library/Homebrew/cmd/tap-info.rb | Sets the failure flag when displaying information for non-installed taps |
| Library/Homebrew/test/cmd/tap-info_spec.rb | Adds integration test verifying failure exit code for unknown taps |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
reviewed
Dec 23, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Looks good so far, thanks!
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the change for #21301
the top-level comment for tap-info is unneccessary, but the linter complained that it was missing, so applying the boyscout-rule here, even if it's unrelated to the PR.
brew lgtm(style, typechecking and tests) with your changes locally?