Set FormulaStruct#deprecate? based on deprecate_args (and same for disable)
#21277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the deprecation/disabling predicate logic for formula API loading to use the presence of deprecate_args and disable_args instead of checking for deprecation_date and disable_date. The predicate method names are also changed from deprecated?/disabled? to deprecate?/disable? to better align with the DSL method names (deprecate!/disable!) and match other predicates in the codebase.
Key changes:
- Predicate methods
deprecated?/disabled?renamed todeprecate?/disable?inFormulaStruct - Logic changed to check presence of
deprecate_args/disable_argsinstead ofdeprecation_date/disable_date - Added test coverage for future-dated deprecation and disabling scenarios
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Library/Homebrew/api/formula_struct.rb | Updated PREDICATES array to use :deprecate and :disable instead of :deprecated and :disabled |
| Library/Homebrew/api/formula.rb | Changed predicate presence checks to use deprecate_args and disable_args instead of date fields |
| Library/Homebrew/formulary.rb | Updated method calls to use new predicate names deprecate? and disable? |
| Library/Homebrew/sorbet/rbi/dsl/homebrew/api/formula_struct.rbi | Updated Sorbet type signatures for renamed predicate methods |
| Library/Homebrew/test/formulary_spec.rb | Added test cases for future-dated deprecation and disabling scenarios, with supporting test data |
Files not reviewed (1)
- Library/Homebrew/sorbet/rbi/dsl/homebrew/api/formula_struct.rbi: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bo98
approved these changes
Dec 18, 2025
acfbe8e to
174cc9b
Compare
5 tasks
MikeMcQuaid
reviewed
Dec 19, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Makes sense, thanks for quick fix @Rylan12!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #21215
Now that we have
deprecate_argsanddisable_argsin the formula JSON, we should use their presence to determine whether to calldeprecate!anddisable!.I changed the predicate methods to
deprecate?anddisable?to match the other predicates that generally match the DSL method name. Alternately, they could be changed todeprecate_args?anddisable_args?if that's more clear.CC: @Bo98