Set deprecate!/disable! args correctly in FormulaStruct
#21215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
include-all-deprecate-disable-args-in-api
to
main
December 11, 2025 15:31
3e9b378 to
42eb599
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the FormulaStruct generation logic to directly use deprecate_args and disable_args from the API instead of reconstructing them from individual fields. The change aligns with the new API format introduced in #21214 that provides the raw arguments originally passed to deprecate! and disable! methods.
Key Changes:
- Replaced manual hash construction from separate date/reason/replacement fields with direct usage of
deprecate_argsanddisable_argsfrom API data - Simplified the code by eliminating field-by-field mapping logic
- Maintained proper reason formatting by converting string reasons to symbols for predefined reason codes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #21214
This PR modifies
FormulaStructto load deprecate/disable info from the newdeprecate_argsanddisable_argsAPI elements. These elements contain the raw arguments that were passed todeprecate!anddisable!, even if they ended up not causing a deprecation/disablement. This ensures that we are syncing the API data with the formula files correctly.This PR is marked as a draft since it cannot be merged until #21214 is merged and has its changes propagated into the API