cask/audit: audit conflicts_with stanza
#21116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: botantony <antonsm21@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds audit functionality to validate the conflicts_with stanza in cask definitions. The audit ensures that casks listed in the conflicts_with declaration actually exist in the core cask tap, helping catch typos and references to non-existent casks.
- Adds
audit_conflicts_withmethod to check for non-existent conflicting casks - Implements helper methods
core_cask_tapandcore_cask_tokensfor cask token lookup - Adds comprehensive test coverage for the new audit functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Library/Homebrew/cask/audit.rb | Implements the audit_conflicts_with method that validates conflicting cask tokens exist, plus helper methods to access core cask tokens |
| Library/Homebrew/test/cask/audit_spec.rb | Adds three test contexts covering no conflicts, existing conflicts, and missing conflicts scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
I expected some audit failures, going to make a PR soon |
8 tasks
Signed-off-by: botantony <antonsm21@gmail.com>
p-linnane
approved these changes
Nov 20, 2025
Member
p-linnane
left a comment
There was a problem hiding this comment.
Awesome! I didn't even realize we weren't checking this.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 21, 2025
cask/audit: audit `conflicts_with` stanza
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?