utils/pypi: retain patches in update_python_resources #21105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the update_python_resources! method to preserve existing resource blocks (including any patches) when the resource's version and checksum haven't changed. This addresses issue #21100 by preventing the loss of version-specific patches during resource updates.
Key changes:
- Added AST parsing to extract existing resource blocks from formula files
- Implemented logic to compare existing resources with new ones and retain unchanged blocks
- Created a new helper method
resource_blocks_from_formulato parse and extract resource blocks
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
p-linnane
approved these changes
Nov 18, 2025
Member
p-linnane
left a comment
There was a problem hiding this comment.
Works great! Thanks so much!
ZhongRuoyu
added a commit
that referenced
this pull request
Nov 21, 2025
Since 1ab3b0c (#21105), `utils/pypi` depends on the `rubocop-ast` gem (via `utils/ast`). We need to ensure that the gem is installed before requiring `utils/pypi` in the affected developer commands. Fixes https://github.com/orgs/Homebrew/discussions/6557.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?When we are updating python resources, if the version and checksum has not changed we retain the existing block instead of generating a new one. This ensures that any version-specific patches are retained.
Closes #21100