Skip to content

Make Sequoia supported#18296

Merged
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
fxcoudert:sequoia_rc
Sep 11, 2024
Merged

Make Sequoia supported#18296
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
fxcoudert:sequoia_rc

Conversation

@fxcoudert
Copy link
Copy Markdown
Member

@fxcoudert fxcoudert commented Sep 9, 2024 •
edited
Loading

macOS Sequoia RC has dropped, and release is near. This PR is open to discuss the timing (we need to coordinate the merge of this PR and make a new release soon/immediately after).

Companion PR: Homebrew/install#878

@fxcoudert fxcoudert mentioned this pull request Sep 9, 2024
Merged
@fxcoudert fxcoudert force-pushed the sequoia_rc branch 2 times, most recently from a0485d0 to 5893597 Compare September 9, 2024 19:44
carlocab
carlocab reviewed Sep 9, 2024
View reviewed changes
carlocab
carlocab reviewed Sep 9, 2024
View reviewed changes
MikeMcQuaid
MikeMcQuaid approved these changes Sep 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! As mentioned: we should aim to merge this as soon as we've got Sequoia CI running on homebrew/core PRs. Anything that needs to wait longer: other folks please suggest changes so we can scope this down to something to merge this week.

carlocab added a commit that referenced this pull request Sep 11, 2024
@carlocab
github_runner_matrix: decouple macOS versions from `MacOSVersion#supp…
d0d1d45 
…orted_release?`

See discussion at #18296.
@carlocab carlocab mentioned this pull request Sep 11, 2024
Merged
7 tasks
carlocab
carlocab approved these changes Sep 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#18306 will decouple these values from what's running in Homebrew/core CI, so this should be good to go any time after that for me.

Bo98
Bo98 approved these changes Sep 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Bo98 Bo98 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All concerns resolved for me too. This can safely sit in master now.

Note that the Homebrew/install PR should wait until the next tag.

MikeMcQuaid
MikeMcQuaid approved these changes Sep 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fxcoudert for opening and @carlocab and @Bo98 for help getting this over the line!

@MikeMcQuaid MikeMcQuaid marked this pull request as ready for review September 11, 2024 08:00
@MikeMcQuaid
Copy link
Copy Markdown
Member

MikeMcQuaid commented Sep 11, 2024

@carlocab Some CI failures here related to GitHub runners; could you take a look? Thanks 🙇🏻

@carlocab
Copy link
Copy Markdown
Member

carlocab commented Sep 11, 2024

Yup, tests just need updating since the tests assume they follow MacOSVersion#unsupported_release?. Will fix shortly.

@carlocab
tests: update determine-test-runners tests
c51bb19 
We've decoupled the macOS versions there from
`MacOSVersion#supported_release?`, so these tests need updating.
@carlocab
Copy link
Copy Markdown
Member

carlocab commented Sep 11, 2024

Pushed an update here. Not complete yet, but will get there soon.

@MikeMcQuaid MikeMcQuaid merged commit b29549e into Homebrew:master Sep 11, 2024
@fxcoudert fxcoudert deleted the sequoia_rc branch September 11, 2024 13:14
@MikeMcQuaid
Copy link
Copy Markdown
Member

MikeMcQuaid commented Sep 11, 2024

Great, thanks for this @carlocab!

@carlocab
Copy link
Copy Markdown
Member

carlocab commented Sep 11, 2024

Huh, didn't expect tests to pass yet. Glad that's all that was needed. 🥳 Will fix up those test assumptions at some point.

@carlocab carlocab mentioned this pull request Sep 13, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@Bo98 Bo98 Bo98 approved these changes

@carlocab carlocab carlocab approved these changes

@p-linnane p-linnane p-linnane approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fxcoudert @MikeMcQuaid @carlocab @Bo98 @p-linnane