chore: remove stale TODO(integrate) markers from already-integrated modules#271
Merged
Merged
Conversation
…odules
Five `// TODO(integrate)` comments and one matching "Not yet integrated"
note were misleading anyone grepping for integration work. Each module
is in fact wired up:
- execpolicy/mod.rs → tools/shell.rs:1322 (load_default_policy)
- sandbox/mod.rs → tools/shell.rs:28, main.rs:2647, tui/approval.rs:30
- sandbox/policy.rs → main.rs:2752, tui/approval.rs:30 (SandboxPolicy)
- command_safety.rs → tools/shell.rs:1321, tools/tasks.rs:13,
tools/approval_cache.rs:26
- tui/streaming/mod.rs → tui/app.rs:38 (StreamingState)
The remaining TODO at mcp.rs:1771 covers a separate "wire legacy sync API
into CLI subcommands or remove" decision and is left in place.
Closes #266
Contributor
There was a problem hiding this comment.
Pull request overview
Removes stale // TODO(integrate) (and one contradictory module-level note) from TUI modules that are already wired into the live build, reducing misleading “not integrated” signals when grepping for integration work.
Changes:
- Deleted five
// TODO(integrate)markers from already-integrated modules. - Removed a
//! NOTE: Not yet integrated...line fromsandbox/mod.rsto align docs with actual usage.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/tui/src/execpolicy/mod.rs | Removes stale “not integrated” TODO at file header. |
| crates/tui/src/sandbox/mod.rs | Removes stale integration TODO and contradictory rustdoc note. |
| crates/tui/src/sandbox/policy.rs | Removes stale integration TODO at file header. |
| crates/tui/src/command_safety.rs | Removes stale integration TODO at file header. |
| crates/tui/src/tui/streaming/mod.rs | Removes stale integration TODO at file header. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five
// TODO(integrate)comments at the top of source files claimed their modules were "not yet integrated" — every one of them is actually wired up in the live build. They were actively misleading anyone grepping the tree for integration work.crates/tui/src/execpolicy/mod.rstools/shell.rs:1322(load_default_policy,ExecPolicyDecision)crates/tui/src/sandbox/mod.rstools/shell.rs:28-33,main.rs:2647,tui/approval.rs:30crates/tui/src/sandbox/policy.rsmain.rs:2752,tui/approval.rs:30(SandboxPolicy)crates/tui/src/command_safety.rstools/shell.rs:1321,tools/tasks.rs:13,tools/approval_cache.rs:26crates/tui/src/tui/streaming/mod.rstui/app.rs:38(StreamingState)Also dropped the matching
//! NOTE: Not yet integratedline fromsandbox/mod.rsso the doc-comment doesn't disagree with the call sites.mcp.rs:1771(Wire legacy sync API into CLI subcommands or remove) is left alone — it covers an unresolved keep-or-delete decision rather than a stale tracking note.Closes #266.
Test plan
grep -rn 'TODO(integrate)' crates/now only matchesmcp.rs:1771cargo check -p deepseek-tui --lockedcleancargo fmt --all -- --check🤖 Generated with Claude Code