Problem
Five source files carry // TODO(integrate) comments claiming their modules are "not yet integrated" into the tool pipeline, but each one is already actively used:
| File |
TODO comment |
Actual status |
crates/tui/src/execpolicy/mod.rs:1 |
"Wire exec-policy into shell tool" |
Used in tools/shell.rs:1512 via Feature::ExecPolicy gate |
crates/tui/src/sandbox/mod.rs:1 |
"Wire sandbox into shell tool" |
Used in tools/shell.rs:28-33 (SandboxManager, SandboxPolicy, SandboxType) |
crates/tui/src/sandbox/policy.rs:1 |
"Wire sandbox policy into shell tool" |
Same as above — policy is threaded through ShellManager |
crates/tui/src/command_safety.rs:1 |
"Wire command safety analysis into shell tool approval flow" |
Used in tools/approval_cache.rs:26 (classify_command) |
crates/tui/src/tui/streaming/mod.rs:1 |
"Wire streaming collector into TUI rendering pipeline" |
Used in tui/ui.rs (438-551) via streaming_state |
The only remaining TODO that may still be valid is mcp.rs:1771 ("Wire legacy sync API into CLI subcommands or remove") — that one warrants a separate decision.
Proposed solution
Replace the // TODO(integrate) lines with brief "Integrated since vX.Y" comments (or remove them entirely) so future readers aren't misled. Optionally add a note in each module's doc comment about where the integration point lives.
Alternatives considered
- Leave the comments as-is — but they actively mislead anyone grepping for integration work
- File one issue per module — but they share the same root cause (stale TODO tracking), so a single cleanup PR is cleaner
Additional context
Found via grep -rn 'TODO(integrate)' crates/. Verified actual usage by searching for module imports and method calls across the codebase.
Problem
Five source files carry
// TODO(integrate)comments claiming their modules are "not yet integrated" into the tool pipeline, but each one is already actively used:crates/tui/src/execpolicy/mod.rs:1tools/shell.rs:1512viaFeature::ExecPolicygatecrates/tui/src/sandbox/mod.rs:1tools/shell.rs:28-33(SandboxManager, SandboxPolicy, SandboxType)crates/tui/src/sandbox/policy.rs:1crates/tui/src/command_safety.rs:1tools/approval_cache.rs:26(classify_command)crates/tui/src/tui/streaming/mod.rs:1tui/ui.rs(438-551) viastreaming_stateThe only remaining TODO that may still be valid is
mcp.rs:1771("Wire legacy sync API into CLI subcommands or remove") — that one warrants a separate decision.Proposed solution
Replace the
// TODO(integrate)lines with brief "Integrated since vX.Y" comments (or remove them entirely) so future readers aren't misled. Optionally add a note in each module's doc comment about where the integration point lives.Alternatives considered
Additional context
Found via
grep -rn 'TODO(integrate)' crates/. Verified actual usage by searching for module imports and method calls across the codebase.