feat(provider): add SiliconFlow China region (siliconflow-CN)#2615
Conversation
Adds SiliconFlow China regional endpoint (api.siliconflow.cn) as new provider variant. Credit: @Raid10Without1 (PR #2588) Co-authored-by: Raid10没有1 <88494433+Raid10Without1@users.noreply.github.com>
There was a problem hiding this comment.
Hmbown has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
Code Review
This pull request introduces support for the SiliconFlow China API provider (SiliconflowCN/SiliconflowCn), setting up its default base URL, configuration overrides, and TUI integration. However, several duplicate match arms for ApiProvider::SiliconflowCn were added in crates/tui/src/config.rs which will lead to compilation errors due to unreachable patterns. These duplicate arms must be removed and the indentation cleaned up.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| ApiProvider::SiliconflowCn => DEFAULT_SILICONFLOW_CN_BASE_URL, | ||
| ApiProvider::SiliconflowCn => DEFAULT_SILICONFLOW_CN_BASE_URL, |
There was a problem hiding this comment.
There is a duplicate match arm for ApiProvider::SiliconflowCn here, which will cause a compilation error due to unreachable patterns. Please remove the duplicate arm and fix the indentation.
ApiProvider::SiliconflowCn => DEFAULT_SILICONFLOW_CN_BASE_URL,| ApiProvider::SiliconflowCn => "siliconflow-CN", | ||
| ApiProvider::SiliconflowCn => "siliconflow-CN", |
There was a problem hiding this comment.
There is a duplicate match arm for ApiProvider::SiliconflowCn here, which will cause a compilation error. Please remove the duplicate arm.
ApiProvider::SiliconflowCn => "siliconflow-CN",| ApiProvider::SiliconflowCn => DEFAULT_SILICONFLOW_CN_BASE_URL, | ||
| ApiProvider::SiliconflowCn => DEFAULT_SILICONFLOW_CN_BASE_URL, |
There was a problem hiding this comment.
There is a duplicate match arm for ApiProvider::SiliconflowCn here, which will cause a compilation error. Please remove the duplicate arm and fix the indentation.
ApiProvider::SiliconflowCn => DEFAULT_SILICONFLOW_CN_BASE_URL,| ApiProvider::SiliconflowCn => "siliconflow-CN", | ||
| ApiProvider::SiliconflowCn => "siliconflow-CN", |
There was a problem hiding this comment.
There is a duplicate match arm for ApiProvider::SiliconflowCn here, which will cause a compilation error. Please remove the duplicate arm and fix the indentation.
ApiProvider::SiliconflowCn => "siliconflow-CN",|
This PR Intrduce some compile error…… 
|
…#2615) Adds SiliconFlow China regional endpoint (api.siliconflow.cn) as new provider variant. Credit: @Raid10Without1 (PR Hmbown#2588) Co-authored-by: Raid10没有1 <88494433+Raid10Without1@users.noreply.github.com>
Adds SiliconFlow China regional endpoint as new provider variant. Closes #2478 (partial). Credit: @Raid10Without1 (#2588).