Cleanup various things noticed while fixing rando generation / debug warp#6152
Merged
serprex merged 5 commits intoHarbourMasters:developfrom Jan 17, 2026
Merged
Cleanup various things noticed while fixing rando generation / debug warp#6152serprex merged 5 commits intoHarbourMasters:developfrom
serprex merged 5 commits intoHarbourMasters:developfrom
Conversation
Contributor
|
|
Contributor
|
I'm not comfortable with the loss of specificity in the source files where |
Contributor
Author
|
working through revising, but |
Contributor
|
I honestly just like the user-friendly reading of Is and IsNot, but maybe we need to revisit the whole Is and IsNot thing if that's the case. |
Contributor
Author
|
@Malkierian updated to Is/IsNot |
Malkierian
approved these changes
Jan 17, 2026
Recent change in init ordering had param hashmap built before static locations setup by hooks
OnGameLoad hook was not being triggered, which time savers rely on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
null
Build Artifacts