Fix rando objects not randomizing#6150
Merged
serprex merged 1 commit intoHarbourMasters:developfrom Jan 17, 2026
Merged
Conversation
13f2098 to
517bd1c
Compare
Contributor
Author
|
Legend on Discord confirmed this fixes issue |
Contributor
|
My first question is, why all the changes from using |
Contributor
Author
|
that was done to address warnings about duplicate macros |
Contributor
Author
|
& latest commit was accidentally done on this branch. Going to split out the rando fix from the cleanup |
Contributor
|
I think I'd prefer to have a separate macro in the header that is named differently for the ones that weren't using the .Get() version. I would have wanted to convert all the ones using the .Get version to append .Get where needed, but that one is used far too often for that change to be desirable. |
Contributor
Author
|
cleanup moved to #6152 |
Recent changes in init ordering had param hashmap built before static locations setup by hooks
Malkierian
approved these changes
Jan 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent change in init ordering had param hashmap built before static locations setup by hooks
Rest of PR is cleanup
Build Artifacts