[Enhancement] Arrow Cycle#6105
Merged
serprex merged 6 commits intoHarbourMasters:developfrom Jan 5, 2026
Merged
Conversation
serprex
reviewed
Jan 5, 2026
serprex
approved these changes
Jan 5, 2026
Patrick12115
pushed a commit
to Patrick12115/Shipwright
that referenced
this pull request
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports over Arrow Cycling from 2S2H. Both versions are functionally equivalent with some minor differences. The main difference is magic consumption which I opted for a different approach. Instead of refunding magic if you cycle away, this prevents the magic consumption on arrow draw and instead consumes when the arrow is actually fired using new VBs. Depending on feedback, that change can stay or go. Doesn't matter to me, I just went with what I personally preferred.
Build Artifacts