Fix Song Shuffle Off#5918
Merged
Malkierian merged 2 commits intoHarbourMasters:develop-copperfrom Nov 4, 2025
Merged
Conversation
…eeds created solely from spoilers.
leggettc18
approved these changes
Nov 3, 2025
Contributor
leggettc18
left a comment
There was a problem hiding this comment.
Approve the changes, I'd delete the comment personally but that's just me, I'll defer to your opinion on that one.
Malkierian
added a commit
to Malkierian/Shipwright
that referenced
this pull request
Nov 7, 2025
* Temporarily fixes Song Shuffle Off causing songs to not be given on seeds created solely from spoilers. * Remove instead of comment.
Pepper0ni
pushed a commit
to Pepper0ni/Shipwright
that referenced
this pull request
Nov 12, 2025
* Temporarily fixes Song Shuffle Off causing songs to not be given on seeds created solely from spoilers. * Remove instead of comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporarily fix Song Shuffle Off causing songs to not be given on saves created solely from spoilers by preventing their locations from not being added to the pool.
Build Artifacts