Cache Spoiler File Exists#5606
Merged
Malkierian merged 1 commit intoHarbourMasters:develop-blairfrom Jun 23, 2025
Merged
Conversation
Malkierian
approved these changes
Jun 22, 2025
ReddestDream
pushed a commit
to ReddestDream/Shipwright
that referenced
this pull request
Jun 24, 2025
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the file choose screen was stuttering. I used the VS profiler and found that
SpoilerFileExistswas being called every frame and that it was reading the spoiler file every time. So I cached the results and reduced the file IO to check if the file still exists and if it has been modified.Note that this could be made unnecessary by caching the results in FileChoose_UpdateRandomizer, but I choose to do it in
SpoilerFileExistsbecause I was unsure how often/likely theSpoilerLogwould change on the menu screen (load straight into a game or generate multiple seeds for testing) and it was easier to do in C++.Before caching:
After caching:
Build Artifacts