Fix Available Checks On Load#5599
Merged
Malkierian merged 2 commits intoHarbourMasters:develop-blairfrom Jun 23, 2025
Merged
Conversation
Malkierian
reviewed
Jun 20, 2025
Malkierian
approved these changes
Jun 22, 2025
ReddestDream
pushed a commit
to ReddestDream/Shipwright
that referenced
this pull request
Jun 24, 2025
* Setup call to RecalculateAvailableChecks instead of direct call. * Remove RecalculateAvailableChecks from CheckTrackerSettingsWindow::DrawElement.
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
* Setup call to RecalculateAvailableChecks instead of direct call. * Remove RecalculateAvailableChecks from CheckTrackerSettingsWindow::DrawElement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #5587 broke Available Checks when first loading into a save. It's because that first
RecalculateAvailableCheckshappens in theGameInteractor::OnLoadGamehook, which apparently runs beforegPlayStategets populated and makesGameInteractor::IsSaveLoadedreturn false.This PR fixes that by setting a flag in
CheckTrackerLoadGamewhich then gets unset inCheckTrackerWindow::DrawElementand runs RecalculateAvailableChecks.Build Artifacts