Change excluded checks to have junk instead of non-advancment.#5592
Merged
Malkierian merged 2 commits intoHarbourMasters:develop-blairfrom Jun 19, 2025
Merged
Change excluded checks to have junk instead of non-advancment.#5592Malkierian merged 2 commits intoHarbourMasters:develop-blairfrom
Malkierian merged 2 commits intoHarbourMasters:develop-blairfrom
Conversation
Malkierian
approved these changes
Jun 17, 2025
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
…urMasters#5592) * Change excluded checks to have junk instead of non-advancment * loud frying pan noises
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where ice traps and potentially other useful non-advancement like shields were being placed on excluded checks. This fix required all items to store their category in the item object, so some extra data needed adding for edge case items and progressives that didn't already have it.
Build Artifacts