Remove size matches contents option#5586
Remove size matches contents option#5586serprex wants to merge 1 commit intoHarbourMasters:developfrom
Conversation
|
I'm a bit reluctant to remove size only, as in theory it should have use as a "good or not" indicator with less info attached than fill CMC, but do know it can be a logical troublemaker due to collision differences, plus the small key thing brought up before... Maybe a "gilded only" setting would be a practical replacement, then everything with a junk texture, as well as skulls, could be "junk" and everything else would be gilded? EDIT: another issue I've had brought up to me is mods which don't have proper chest setups might need size as a fallback, I'm less familiar with this issue though as I don't get involved in the modding side |
|
There was talk of pulling back features, which resulted in cutting some link animations from pause menu & potion values. This seemed like a candidate to cull. The extra information seems fine, especially since it's more interesting to gate behind stone. But maybe this could creep further & we could have gilded only be upped to full texturing with stone of agony (could handle this in settings by storing CSMC type on both csmc option itself & chests of agony, also opens up troll options like csmc enabled & stone of agony disabling csmc..) Mod issue might explain why 5523 had settings on size only. Perhaps we can agree that size can be removed once mod compat is worked out In meantime I'll split this PR in 2: #5588 |
609949c to
6d25c57
Compare
fca8954 to
d653ee9
Compare
|
replaced by #6085 |
closes #5523
Build Artifacts