Skip to content

Change Key Rings to Major Item#5523

Closed
piebandit wants to merge 1 commit intoHarbourMasters:develop-blairfrom
piebandit:keyrings-as-major-chest
Closed

Change Key Rings to Major Item#5523
piebandit wants to merge 1 commit intoHarbourMasters:develop-blairfrom
piebandit:keyrings-as-major-chest

Conversation

@piebandit
Copy link

Change to key rings to the "Major" Item category considering they consist of all keys for a dungeon or location.

Changes Key rings to be in major chests instead of small key chests.
@piebandit piebandit changed the title Update item_list.cpp Change Key Rings as Major Items May 20, 2025
@piebandit piebandit changed the title Change Key Rings as Major Items Change Key Rings to Major Item May 20, 2025
@serprex
Copy link
Contributor

serprex commented May 20, 2025

Not a fan of having keyrings not use CSMC for keys

@Pepper0ni
Copy link
Contributor

Having keyrings classed differently to small keys is wierd as they provide small keys, and the key models ensure that check matches contents still marks them as important. They should not be moved to major items IMO, and unless someone comes up with strong arguments otherwise this PR should be closed.

@Malkierian
Copy link
Contributor

Going to have to agree with the others on this one. I'm just not seeing the reasoning for it.

@piebandit
Copy link
Author

I think the problem is that if you only use Classic then they appear in regular small chests. If there could be a middle ground where they could be bigger if using the classic setting then maybe that's a better solution?

@serprex
Copy link
Contributor

serprex commented May 21, 2025

Personally, I think chest size matching contents should be removed given textures. But having chest be large for keys or keyrings makes sense

@Malkierian
Copy link
Contributor

I'm not sure what you're referring to here with "classic". Size Only for CSMC?

@Pepper0ni
Copy link
Contributor

I assume so, as CSMC came before textures on console dev

@Malkierian
Copy link
Contributor

Yeah, considering we're leaning toward just removing the size portion of CSMC in favor of more expanded textures (for multiple reasons), I'm going to go ahead and close this.

@Malkierian Malkierian closed this Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants