Fix King Dodongo entrance crash in grotto mixed pool entrance rando#5572
Merged
Malkierian merged 1 commit intoHarbourMasters:develop-blairfrom Jun 11, 2025
Merged
Conversation
Malkierian
approved these changes
Jun 11, 2025
ReddestDream
pushed a commit
to ReddestDream/Shipwright
that referenced
this pull request
Jun 16, 2025
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5562
The crash is stemming from an OOB write in randomizer_entrance.c, which was overwriting memory corresponding to the King Dodongo scene table entry.
With the introduction of mixed pools, entrances can be shuffled to grottos, which fall outside the range of the vanilla entrance table that is used in clearing the continuing background music flag to account for the GC Lost Woods shortcut and Hyrule Castle -> Market entrances.
This fix simply stops this procedure from happening if the write would be OOB (aka any grotto entrance/exit). Tested and couldn't find any grotto entrances/exits that continued background music, but it's still likely there's a better/more explicit solution than this.
Build Artifacts