Skip to content

Convert actor health bars to use ObjectExtension#5565

Merged
Malkierian merged 1 commit intoHarbourMasters:developfrom
Rozelette:healthbar-ext
Jun 11, 2025
Merged

Convert actor health bars to use ObjectExtension#5565
Malkierian merged 1 commit intoHarbourMasters:developfrom
Rozelette:healthbar-ext

Conversation

@Rozelette
Copy link
Contributor

@Rozelette Rozelette commented Jun 9, 2025

This gets us our Actor struct back to vanilla!

Build Artifacts

@Malkierian
Copy link
Contributor

I don't suppose there's a way to accomplish this without the added include? I can just imagine them getting out of hand in some instances.

@Malkierian
Copy link
Contributor

Though I want to clarify that's not blocking from me, added includes are better than significant src code changes. Just wondering.

@Rozelette
Copy link
Contributor Author

Rozelette commented Jun 11, 2025

I can just imagine them getting out of hand in some instances.

It is a natural result of splitting every feature into it's own file. A solution would be to at least combine the headers, maybe 1 for each kind of object (Actor, PlayState, etc).

@Malkierian
Copy link
Contributor

I would be OK with that. I know we would want to avoid adding another OTRGlobals situation with them all in one header, but some grouping would reduce new include lines. Probably something we can deal with later as more things get converted, though. Maybe it's actually a non-issue.

@Malkierian Malkierian merged commit dbc2ff0 into HarbourMasters:develop Jun 11, 2025
6 checks passed
krazyjakee pushed a commit to krazyjakee/OOT that referenced this pull request Sep 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants