Merged
Conversation
716fac6 to
58e378d
Compare
e26503e to
31e59fd
Compare
TheLynk
added a commit
to TheLynk/Shipwright
that referenced
this pull request
Jun 23, 2025
51c30e0 to
4aed7fe
Compare
Contributor
Author
|
Figured out the pause menu jank: I was only setting rand inf without updating inventory contents. Fixed by replacing |
5f96d1d to
0c9dc99
Compare
Closed
Contributor
|
So was this not even intended to actually add mask checks? |
Contributor
Author
|
Correct, child trade quest would be a separate project |
2861134 to
f619239
Compare
Pepe20129
suggested changes
Dec 30, 2025
Contributor
Pepe20129
left a comment
There was a problem hiding this comment.
One small thing.
Also, I still think that we should turn the mask shop into a regular shop if shopsanity and the mask rando are enabled.
Contributor
Author
|
Trying to keep this PR's scope minimal. Future follow ups (mask abilities, mask trade quest checks, mask as an extra shop) would be in future PRs |
Future improvements can build on this, giving masks abilities, or adding checks for trading mask to someone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Future improvements can build on this, giving masks abilities, or adding checks for trading mask, or turning mask shop into a random shop
Build Artifacts