Add ShuffleSongs.cpp & RO_SONG_SHUFFLE_OFF#5534
Add ShuffleSongs.cpp & RO_SONG_SHUFFLE_OFF#5534Malkierian merged 4 commits intoHarbourMasters:developfrom
ShuffleSongs.cpp & RO_SONG_SHUFFLE_OFF#5534Conversation
| AddItemsToPool(PendingJunkPool, songList); | ||
| } | ||
| } else { | ||
| ctx->PlaceItemInLocation(RC_SHEIK_IN_FOREST, RG_MINUET_OF_FOREST, false, true); |
There was a problem hiding this comment.
I may be misremembering, but I think we've been trying to get away from explicitly placing items in their vanilla locations when their shuffles are off because they get added to the spoiler when they don't need to be. Would appreciate some input from others on this.
There was a problem hiding this comment.
They don't appear in the spoiler file, iirc it's due to the change in context.cpp.
There was a problem hiding this comment.
Hmm, maybe it wasn't the spoiler that was the issue then, but I could have sworn there was some problem that was identified with explicitly placing vanilla.
Co-authored-by: Philip Dubé <serprex@users.noreply.github.com>
Malkierian
left a comment
There was a problem hiding this comment.
Well, I guess if we need to fully divest from the vanilla placements, it can happen later.
* ShuffleSongs.cpp * Address review and fix build * Update soh/soh/Enhancements/randomizer/settings.cpp Co-authored-by: Philip Dubé <serprex@users.noreply.github.com> * Change back to "Off" --------- Co-authored-by: Philip Dubé <serprex@users.noreply.github.com>
null
Build Artifacts