Conversation
cb8b83c to
22eac0c
Compare
|
First commit is not about warnings, but instead addressing TODO about whether uint8_t is necessary I've updated hint code to use size_t in places where the indexes are just being passed around, & not actually stored anywhere. At best |
briaguya0
left a comment
There was a problem hiding this comment.
overall looks great! couple little comments, one has a small suggestion
|
this seemed to fix something for @Pepper0ni |
|
You've marked a lot of classes |
Pepper0ni
left a comment
There was a problem hiding this comment.
The hint stuff seems fine, but I can't give an opinion on Rozelette's comment.
warning: second argument to 'va_arg' is of promotable type 's16' (aka 'short'); this va_arg has undefined behavior because arguments will be promoted to 'int' [-Wvarargs]
* use size_t instead of uint8_t for hint ids * va_arg int instead of s16 warning: second argument to 'va_arg' is of promotable type 's16' (aka 'short'); this va_arg has undefined behavior because arguments will be promoted to 'int' [-Wvarargs] * more issues like HarbourMasters#5443
null
Build Artifacts