Warnings Round 2 (mostly Rando)#5486
Merged
Malkierian merged 4 commits intoHarbourMasters:developfrom May 17, 2025
Merged
Conversation
Handle order of operations warning in FasterHeavyBlockLift.
serprex
approved these changes
May 14, 2025
louist103
reviewed
May 14, 2025
… them in for the static casts in draw.cpp.
Merged
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
* Handle virtually all warnings in `soh/Enhancements/randomizer`. Handle order of operations warning in FasterHeavyBlockLift. * Missed a few. * Add float-specific versions of some M_PI and M_SQRT defines, and swap them in for the static casts in draw.cpp. * Swap a static cast for M_PIf in check tracker code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles virtually all warnings in
soh/Enhancements/randomizer/*. The only exception is whenboost::hash32is used, where a warning of conversion fromsize_ttouint32_tis raised from withinhash_32.hpp. Considering my initial attempts to fix didn't work, and we're working towards removing boost anyway, I figured I'd just leave those for now.Also handles order of operations warning in
FasterHeavyBlockLift.Build Artifacts