New options that affect feeding Jabu-Jabu#5397
Merged
Malkierian merged 6 commits intoHarbourMasters:develop-blairfrom Jun 15, 2025
Merged
New options that affect feeding Jabu-Jabu#5397Malkierian merged 6 commits intoHarbourMasters:develop-blairfrom
Malkierian merged 6 commits intoHarbourMasters:develop-blairfrom
Conversation
595153c to
d27b16a
Compare
This reverts commit 2a1974a.
Malkierian
reviewed
Jun 11, 2025
Malkierian
approved these changes
Jun 12, 2025
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
* New options that affect feeding Jabu-Jabu * Add hints for what Jabu-Jabu wants * Roll back "key" settings to just closed/open, finish rando logic * Revert "Add hints for what Jabu-Jabu wants" This reverts commit 2a1974a. * Fix vanilla enhancement disabler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5313
I was thinking of adding an option to choose what Jabu-Jabu wants to be fed, like a random collectible (e.g. Deku Sticks) or be played a song, but that's enough work to be out-of-scope. Instead, this is now just a carbon copy of Sleeping Waterfall.
I still want to give changing requirements a try at some point. Maybe Sleeping Waterfall unlocks with a different song besides ZL. But that'll require its own structure that's above my pay grade ATM.
Build Artifacts