Fix boss key kaleido text for NTSC#5389
Fix boss key kaleido text for NTSC#5389leggettc18 merged 1 commit intoHarbourMasters:develop-blairfrom
Conversation
|
So the texture for the BigKeyItemNameTex doesn't visibly appear anywhere but the game tries to load it anyway? Am I understanding that right? |
|
The game was crashing, as it tries to load the resource by that name, but it didn't exist |
|
OK, since this one is fixing a crash should we make it actually require an OTR regen? Or is there not a way to do that for only the NTSC versions? |
|
There is not a way currently to selectively do a regen. We can just call it out again in the changelog. |
|
Alright, figured I'd ask. Would be nice if we could trigger rebuilds for only NTSC, but at this point by the time we could implement it we probably wouldn't need it anymore. |
|
Confirmed I could repeat the crash pre-regen and no crash post-regen. Merging now. |
The texture name for the boss key item name text in kaleido is named
gBigKeyItemNameENGTexin the NTSC versions, but namedgUnusedBigKeyItemNameENGTexin the PAL versions. The code is usinggUnusedBigKeyItemNameENGTexto for rendering, causing NTSC to crash when hovering over the boss key.I think
gBigKeyItemNameENGTexwould be the better name overall, but for a develop-blair bugfix, I'd rather have the NTSC OTRs require regen instead of the PAL ones. We can always rename and change the code later for a 9.1.0 release in the future.Build Artifacts