Skip to content

Fix hud position reset#5385

Merged
leggettc18 merged 1 commit intoHarbourMasters:develop-blairfrom
Malkierian:fix-hud-position-reset
Apr 12, 2025
Merged

Fix hud position reset#5385
leggettc18 merged 1 commit intoHarbourMasters:develop-blairfrom
Malkierian:fix-hud-position-reset

Conversation

@Malkierian
Copy link
Contributor

@Malkierian Malkierian commented Apr 11, 2025

Changes the Reset All callback back to CosmeticsEditor_ResetAll, because it's already set up to not reset HUD position stuff. I tried replacing stuff in that function with CVarClearBlock calls, but it reloads the CVars after each one because of how that flow works, and it's extremely unperformant.

Build Artifacts

…ause it's already set up to not reset HUD position stuff.
@leggettc18
Copy link
Contributor

Have you already confirmed that CosmeticsEditor_ResetAll properly resets everything except for the HUD position stuff? I would worry about it potentially not resetting some of the more recent stuff (unless it was still in use somewhere for something else?)

@leggettc18
Copy link
Contributor

I did some manual testing here, confirmed that most of the stuff in the "Silly" tab does not get reset by the "Reset All" button. Is that intentional?

@Malkierian
Copy link
Contributor Author

No, that's just because the silly tab doesn't have an array of CVars used there, so it isn't hooked up to the old reset function.

@leggettc18
Copy link
Contributor

Any chance you could add them? Feels to me like they should be reset when you hit Reset All

@Archez
Copy link
Contributor

Archez commented Apr 12, 2025

In my mind I think it should only reset colors. The silly tab should have its only reset. The accompanying RandomizeAll button only randomizes colors. We can always rename the funcs if that's an issue.

@leggettc18
Copy link
Contributor

Ah that is fair, wasn't thinking about the Randomize All button.

@leggettc18 leggettc18 merged commit 1416b24 into HarbourMasters:develop-blair Apr 12, 2025
6 checks passed
@Malkierian Malkierian deleted the fix-hud-position-reset branch April 13, 2025 02:51
krazyjakee pushed a commit to krazyjakee/OOT that referenced this pull request Sep 6, 2025
…ause it's already set up to not reset HUD position stuff. (HarbourMasters#5385)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants