Looks good, but need to run clang-format

Is this new behavior? Doesn't seem quite right.

Is that actually docked to the main viewport, or did you dock that while the menu was open?

I don't believe the menu was open no. It also only seems to happen with the Check tracker.

Actually Entrance tracker seems to do it too, just can't manually edit it's opacity so it's only partially see-through.

Item Tracker is fine though, only difference I'm aware of is the Item Tracker doesn't have a close button.

OK yeah forget what I said about Check Tracker, it happens with every window I've tried except for the Item Tracker

What do you mean by "every window"?

Every ImGui window that you can pop out and dock to the sides of the main gameplay window has this behavior. Check Tracker, Entrance Tracker, Save Editor, etc. It's most noticeable with the Check Tracker because you can make it fully transparent, but all those other windows do a similar echo of the game screen at the moment they are docked. I should also note this actually may not be new behavior, it also happened for me after downloading a different build for another PR.

What you're seeing behind the check tracker currently is the last state of the framebuffer from the game before the game was limited to the new space calculated from the dock. The Check Tracker is the way it is because it can go transparent, but you shouldn't be seeing anything behind any window that doesn't have color customization that allows transparency.

The reason the check tracker wasn't covered was because I didn't realize its calls to BeingFloatingWindows wasn't the same as the Item Tracker's.

And, the reason the entrance tracker is doing it is because it defaults to a bit of transparency for some reason.

It's faint, but I can see it behind other windows as well. They are normally semi-transparent when they are entirely inside the SoH window, so if they get docked they still have this semi-transparency. Looks like this isn't new behavior to this PR though, so I can just make an issue for this to be solved later.

That being said, what is something I can do that wouldn't work before this PR that does work after it (or at least behaves differently)?

That part of it really is outside the scope of this PR, the framebuffer issue has been longstanding for months.

Right right, like I said I'll make an issue for that if there isn't already one, but what is something I can do that wouldn't work before this PR that does work after it (or at least behaves differently)? I think I just don't have a clear idea of what is actually different with this new flow.

Before this, having the item tracker fully transparent in windowed mode wouldn't go opaque when docked, and would therefore have ghosting with the tooltips.

Also, the item tracker has never had a close button in windowed mode that I can remember. Certainly didn't in 9.0.0 or 8.0.6

Yeah it's never had a close button, I wasn't implying that it was incorrect for it not to have one.

Can you elaborate how to achieve that behavior with the ghosting? I'm running one of the other currently open PRs trying to get this to happen so I can confirm, but I can't seem to replicate the ghosting behavior at all.

Set the item tracker window opacity to 0, dock it, and move the mouse around over the items.

I downloaded the build of your Cosmetics Reset PR, extracted it to a clean directory, and this is the behavior I'm getting. I'm not trying to say you're wrong, but clearly I'm missing something here.

Oh, right, this modifies the routine so that when you dock tracker windows with themselves, they don't go opaque, but that the opaque clamping only happens when you dock the trackers with the main dockspace that changes the resolution of the game output.

And by "tracker windows" are you meaning just the Item Tracker windows? Because as posted above, the Check Tracker remains transparent when docked to the main game window.

The reason the check tracker wasn't covered was because I didn't realize its calls to BeginFloatingWindows wasn't the same as the Item Tracker's.

So this also brings the check tracker up to date with what the item tracker was doing with the last PR, as well as applying the same constraints this PR applies to the item tracker.

Ok I think I get it now. Regardless these changes don't appear to cause any issues so I'll call it good lol.