Fix Adult Fishing as Child Softlock#5377
Merged
leggettc18 merged 3 commits intoHarbourMasters:develop-blairfrom Apr 10, 2025
Merged
Fix Adult Fishing as Child Softlock#5377leggettc18 merged 3 commits intoHarbourMasters:develop-blairfrom
leggettc18 merged 3 commits intoHarbourMasters:develop-blairfrom
Conversation
leggettc18
approved these changes
Apr 10, 2025
Contributor
leggettc18
left a comment
There was a problem hiding this comment.
Good catch, shame we missed it the first time.
Contributor
|
Did hands-on testing, confirmed fixed. |
Contributor
|
Can you also update the comment in |
leggettc18
approved these changes
Apr 10, 2025
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
* pass a pointer not a pointer to a pointer * update GIVanillaBehavior comment * also drop this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the hook code to correctly use Fishing* instead of VBFishingData* resulted in passing a pointer to the pointer (&this - Fishing**), causing a softlock when the switch variable was only updated on this copy instead of live. Passing the pointer itself resolves this.
Build Artifacts