French Rando : Add missing text + some tweaks#5327
French Rando : Add missing text + some tweaks#5327leggettc18 merged 8 commits intoHarbourMasters:develop-blairfrom
Conversation
…em.cpp Co-authored-by: Extloga <141232749+Extloga@users.noreply.github.com>
Co-authored-by: Extloga <141232749+Extloga@users.noreply.github.com>
Co-authored-by: Extloga <141232749+Extloga@users.noreply.github.com>
|
I found another missing text, I think. It seems related anyway ? In French the shops won't display the yellow text indicating the price. Out of curiosity I checked the German and it's even worse, all the text is bugged out, but I'm guessing it's because of something else.
|
The issue emerge from a refactor that has been done with Rando V3 and is not related to missing text, the fix for the price thing is there: #5312 |
My bad then ! Should've looked. |
|
I just merged #5312 and it looks like there's some conflicts, hopefully nothing too major but let me know if it's too hairy and I'll see what I can do to help. |
Should be okay to merge now, I wouldn't mind a second eye to be extra safe tho |
|
Sounds good, soon as it builds I'll get right on it. |
Pepper0ni
left a comment
There was a problem hiding this comment.
I can't speak for the contents of the translation, but it seems fine on a technical level.
|
Yup, I was worried for the technical side of it, since I resolved the conflict directly from the web interface |
* Should cover everything, I hope * One last * final tweaks for real this time * Update soh/soh/Enhancements/randomizer/3drando/hint_list/hint_list_item.cpp Co-authored-by: Extloga <141232749+Extloga@users.noreply.github.com> * Update soh/soh/Enhancements/randomizer/3drando/shops.cpp Co-authored-by: Extloga <141232749+Extloga@users.noreply.github.com> * Update soh/soh/Enhancements/randomizer/3drando/shops.cpp Co-authored-by: Extloga <141232749+Extloga@users.noreply.github.com> * TODO_TRANSLATE is a macro no a string Hato --------- Co-authored-by: Extloga <141232749+Extloga@users.noreply.github.com>
* Should cover everything, I hope * One last * final tweaks for real this time * Update soh/soh/Enhancements/randomizer/3drando/hint_list/hint_list_item.cpp Co-authored-by: Extloga <141232749+Extloga@users.noreply.github.com> * Update soh/soh/Enhancements/randomizer/3drando/shops.cpp Co-authored-by: Extloga <141232749+Extloga@users.noreply.github.com> * Update soh/soh/Enhancements/randomizer/3drando/shops.cpp Co-authored-by: Extloga <141232749+Extloga@users.noreply.github.com> * TODO_TRANSLATE is a macro no a string Hato --------- Co-authored-by: Extloga <141232749+Extloga@users.noreply.github.com>
Fixes #5309
And probably all other subsequent issues from missing texts
I think I don't miss anything? I hope so
Build Artifacts