Skip to content

Better verbose output for clang-format#5306

Merged
Archez merged 1 commit intoHarbourMasters:developfrom
Archez:clang-format-verbose
Apr 3, 2025
Merged

Better verbose output for clang-format#5306
Archez merged 1 commit intoHarbourMasters:developfrom
Archez:clang-format-verbose

Conversation

@Archez
Copy link
Contributor

@Archez Archez commented Apr 3, 2025

This updates the format scripts to output the file its working on and how many X out of Y the status is on.

Setting --verbose on the linux/mac script was sufficient for this behavior.

In the windows powershell script, we were already looping and printing the file name, the loop is updated to now have the current index out of length printed as well. (Couldn't use --verbose since we execute clang-format multiple times. Trying to pass all files direct to clang-format led to a "command too long" issue in powershell's CreateProcess)

Example:

Formatting [1/1296] soh/platform/pathconf.c
Formatting [2/1296] soh/resource.h
Formatting [3/1296] soh/soh/util.cpp
Formatting [4/1296] soh/soh/mixer.c
Formatting [5/1296] soh/soh/CrashHandlerExp.h
Formatting [6/1296] soh/soh/stubs.c
Formatting [7/1296] soh/soh/config/ConfigMigrators.h
Formatting [8/1296] soh/soh/config/ConfigUpdaters.h

Build Artifacts

@Archez Archez merged commit 2deea6e into HarbourMasters:develop Apr 3, 2025
6 checks passed
@Archez Archez deleted the clang-format-verbose branch April 3, 2025 19:23
xxAtrain223 pushed a commit to xxAtrain223/Shipwright that referenced this pull request May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants