Implement Log Level selector setting#5263
Conversation
|
Updated and feedback addressed. |
briaguya0
left a comment
There was a problem hiding this comment.
at first the fact that it doesn't change log file output felt a bit odd but i figure we'd end up wanting extra logic to make sure people don't have empty logs when trying to diagnose bug reports (which feels out of scope for this PR)
|
What do you mean by changing log file output? |
|
Oh, wait, you mean the log file output remains the same regardless? No, that probably should be handled. I thought this would change all logging. The main point was to be able to remove traces when debugging. |
i was going off Shipwright/soh/soh/SohGui/SohMenuDevTools.cpp Lines 93 to 94 in cffe16f so i assumed it was intentional |
|
Hmm. Well, it was copied over from 2ship, I believe, so that may be how they did it over there, too. But yeah, the main thing was the console, because the traces could make debug really chug sometimes. |
* Implement Log Level selector setting. * run clang * Enum for default value. * PR feedback: use CVAR_DEVELOPER_TOOLS in CVar builder. * Slight change to try to force a PR update. * screw you clang
null
Build Artifacts