Skip to content

FasterShadowShip.cpp#5114

Merged
Malkierian merged 1 commit intoHarbourMasters:developfrom
serprex:speedboat
Jun 19, 2025
Merged

FasterShadowShip.cpp#5114
Malkierian merged 1 commit intoHarbourMasters:developfrom
serprex:speedboat

Conversation

@serprex
Copy link
Contributor

@serprex serprex commented Mar 14, 2025 •
edited
Loading

Makes boat 6x faster with some logic to slow down while Stalfos active & avoid clipping Link off back

Build Artifacts

aMannus
aMannus previously requested changes Mar 16, 2025
View reviewed changes
Copy link
Contributor

@aMannus aMannus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know 3DS had the speedup only apply when there's no stalfos within a certain radius of you, which honestly I think I'd prefer. But I'd like to hear what others think about this.

Aside from that, some feedback on your usage of the VB should.

@serprex serprex force-pushed the speedboat branch 2 times, most recently from a306a98 to 73eede4 Compare March 18, 2025 04:12
@serprex serprex requested a review from aMannus March 18, 2025 14:19
@lilacLunatic lilacLunatic mentioned this pull request Apr 4, 2025
Open
@Pepper0ni
Copy link
Contributor

Pepper0ni commented Apr 7, 2025

I personally would use the version that does it when no stalfos exist, but given it's possible to just cheese the stalfos by standing on the stern, I can see people wanting a full skip too, so a 3 way dropdown makes sense.

@Pepper0ni
Copy link
Contributor

Pepper0ni commented Apr 7, 2025

Had a test with develop merged in, and it doesn't seem to be working

Pepper0ni
Pepper0ni reviewed Apr 7, 2025
View reviewed changes
@serprex serprex force-pushed the speedboat branch 2 times, most recently from 2e2976f to 7dfcf7b Compare April 7, 2025 14:49
Pepper0ni
Pepper0ni approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@Pepper0ni Pepper0ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a 3 way option, but I'm not going to block over it. Kinda makes me want a skip for the initial waiting with the cutscene off but removing all those delays is a massive job.

@serprex
Copy link
Contributor Author

serprex commented Apr 7, 2025

fwiw I'm against adding total skip, if you want to cheese Stalfos then you should have to cheese them

@serprex
FasterShadowShip.cpp
7133eba 
Makes boat 25x faster
@serprex
Copy link
Contributor Author

serprex commented May 30, 2025

@aMannus hook code updated & radius implemented

@serprex
Copy link
Contributor Author

serprex commented Jun 10, 2025

@Malkierian since you reviewed the other time saves I worked on more recently, might make sense for you to take over reviewing this one. aMannus's feedback here was due to me not understanding how to properly alter decomp code with hooks, which I've since learnt & this PR has been updated to reflect

@Malkierian Malkierian dismissed aMannus’s stale review June 18, 2025 20:18

Request addressed.

@Malkierian Malkierian merged commit 180d6a1 into HarbourMasters:develop Jun 19, 2025
6 checks passed
krazyjakee pushed a commit to krazyjakee/OOT that referenced this pull request Sep 6, 2025
@serprex @krazyjakee
FasterShadowShip.cpp (HarbourMasters#5114)
10b26ef 
Makes boat 25x faster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Malkierian Malkierian Malkierian approved these changes

@aMannus aMannus Awaiting requested review from aMannus

+1 more reviewer

@Pepper0ni Pepper0ni Pepper0ni approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serprex @Pepper0ni @Malkierian @aMannus