Conversation
|
Would be nice to have a similar thing to boss souls where there's a generic model for "moves" we can re-use in the future as well, with a detailed model using Link doing the crawl animation (and other animations if we ever shuffle other moves). |
|
Could also maybe be applied to shuffle swim instead of the bronze scale. |
IMO that one atleast kinda makes sense considering it's a progressive upgrade for diving and thematically fits with the ability upgrade in-game. |
56ce975 to
5e2cb0e
Compare
|
does graphic block this PR? similarly, I'm thinking of going ahead after this & doing more (strength 0, climb, open, roll, speak), bronze scale seems like a good placeholder in meantime, but it could also be blue smoke like the white smoke in NPC souls (blue like the A button) |
|
Yeah I'd rather not have WIP models in use, so a 3D model would block this imo. We have several talented 3D artists willing to help so there's no reason not to. The animated link model with the action's animation wouldn't of course, although if we would (with a fallback to a model like boss souls), we'd be ready to use it for future shuffles too. |
|
An alternative idea I had is to come up with a flavorful item for the ability. Something like a "Groundhog Charm" in this case, for example. |
0a6f773 to
4ae46f9
Compare
Pepper0ni
left a comment
There was a problem hiding this comment.
A couple of small things while we wait for a model
soh/soh/Enhancements/randomizer/3drando/hint_list/hint_list_item.cpp
Outdated
Show resolved
Hide resolved
980824e to
7c37d9f
Compare
42fbd7f to
3b2b91d
Compare
|
Updated this with an attempt at some kind of knee pads graphics |
dbdff74 to
5a0adee
Compare
Pepper0ni
left a comment
There was a problem hiding this comment.
Main issue is the bad no-translation marking, the rest is logic structure nitpicks so we can start cleaning up overworld
soh/soh/Enhancements/randomizer/3drando/hint_list/hint_list_item.cpp
Outdated
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/location_access/overworld/castle_grounds.cpp
Outdated
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/location_access/overworld/kokiri_forest.cpp
Outdated
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/location_access/overworld/castle_grounds.cpp
Outdated
Show resolved
Hide resolved
|
I translated that one in french back in the day, but it seems you keep losing my translations on your shuffles every time you're force pushing o7 |
Pepper0ni
left a comment
There was a problem hiding this comment.
An issue with one of the new regions, and make sure it passes checks
soh/soh/Enhancements/randomizer/location_access/overworld/castle_grounds.cpp
Outdated
Show resolved
Hide resolved
how do I keep messing this up, sorry. I thought |
No worries it's fine, if you had more shuffle merged or still open if you could double check the PRs I made from your fork if they're present in this repo, that would save me to check everything every time And if you needs french translation on future draft/prs, tag me on it instantly, so I'll provide them when I can :) |
40be387 to
41cddbb
Compare
Pepper0ni
left a comment
There was a problem hiding this comment.
Fix conflicts and it's a last minute sanity test from in, though I would like a better graphic at some point
41cddbb to
faecbbf
Compare
Only has a half dozen logical implications:
Build Artifacts