Skip to content

rocksanity#5015

Open
serprex wants to merge 5 commits intoHarbourMasters:developfrom
serprex:rocksanity
Open

rocksanity#5015
serprex wants to merge 5 commits intoHarbourMasters:developfrom
serprex:rocksanity

Conversation

@serprex
Copy link
Contributor

@serprex serprex commented Feb 7, 2025

@TheLynk
Copy link
Contributor

TheLynk commented Feb 7, 2025

KF 4 Rock no shuffle
image
image

@TheLynk
Copy link
Contributor

TheLynk commented Feb 7, 2025

boulders respawn after break
https://youtu.be/15Cdjv7r2uQ

@serprex
Copy link
Contributor Author

serprex commented Feb 7, 2025

  1. 3 of those rocks are indestructable, but will add the lone rock
  2. boulders I circumvent them setting flags to not respawn so one doesn't lose access to drop if they break boulder without collecting drop. I'll make sure that breaking it second time works, but I think better is to let them set flag, & only block prevention of spawning when item isn't collected

@TheLynk
Copy link
Contributor

TheLynk commented Feb 8, 2025

missing 2 rock near gossip stone in dmc

@serprex serprex force-pushed the rocksanity branch 4 times, most recently from eb9a67b to cc442e9 Compare February 14, 2025 06:35
@serprex serprex marked this pull request as ready for review February 17, 2025 14:11
@Dreamwrecker
Copy link

Kokiri forest rock behind know it all's house, BotW basement boulder 1, and all of the bronze boulders in Goron City maze are not randomized for me. They show up in the check tracker and in the spoiler, but in game they don't drop anything nor are they highlighted green.

07-08-36-44-63.json

@Dreamwrecker
Copy link

BotW boulder 1 is not randomized despite appearing in the check tracker. This is vanilla, not MQ. Goron City maze rock as well.

Rocksanity BotW boulder 1

@Dreamwrecker
Copy link

Goron City maze rock does work, but it's entry doesn't clear from the check tracker.

This setting adds a ton of bombs to the drop table, but no chus. If logic has you get bombchu bag before bomb bag, you might be in for a ton of grass/dampe pot farming. Maybe a sub option/enhancement to change [bombs] in the item table to [explosives]?

@serprex
Copy link
Contributor Author

serprex commented Mar 5, 2025

The heart / bomb stuff was because RG_NONE was causing issues. I'd like to have boulders instead add random junk, but that requires adjusting utility function being used

@serprex serprex force-pushed the rocksanity branch 3 times, most recently from cef050b to a6ff151 Compare March 18, 2025 16:53
@serprex serprex force-pushed the rocksanity branch 2 times, most recently from d90fa08 to 5159b98 Compare March 28, 2025 01:44
@serprex serprex force-pushed the rocksanity branch 2 times, most recently from d65d72c to 6631441 Compare April 2, 2025 20:51
@TheLynk
Copy link
Contributor

TheLynk commented Apr 2, 2025

image
Missing DMC GOSSIP ROCK 1 and DMC GOSSIP ROCK 2

@serprex
Copy link
Contributor Author

serprex commented Apr 2, 2025

@TheLynk DMC gossip rocks are child only. Updated logic

@TheLynk
Copy link
Contributor

TheLynk commented Apr 2, 2025

image
Bad Logic GV_BRONZE_BOULER_1 & GV_BRONZE_BOULER_2

@lilacLunatic
Copy link
Contributor

The small rock in goron city maze is tied to the GC_MAZE_SILVER_BOULDER_30 instead of GC_MAZE_ROCK. I don't know if there is a check that clears the latter.

@TheLynk
Copy link
Contributor

TheLynk commented Apr 24, 2025

Do you still need test or do you need something else for it to be a merge?

@serprex
Copy link
Contributor Author

serprex commented Apr 24, 2025

CSMC assets will be required before merging. Around that time I'll also need to make the code give better names to all the checks instead of relying on macros so much

@serprex serprex force-pushed the rocksanity branch 3 times, most recently from 445bda9 to fe740c2 Compare June 20, 2025 00:44
@TheLynk
Copy link
Contributor

TheLynk commented Jun 20, 2025

You think it is possible that you add an option that it makes that when it is activated in the place that the item drop to the land it is directly given to the player to avoided the worries in the zone of the "goron maze" or all the drops we almost each time in other boulder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants