remove out of bounds array access#4751
Conversation
There was a problem hiding this comment.
Thanks for the contribution! Typically what I'll do in these cases is check decomp repo to see if they have this bug documented, and submit a PR to document it with a comment, then add the comment in our repo stating we opted to fix it. (Example here)
You don't have to submit this to decomp if you don't want but it would be appreciated, at the very least we want it documented in our repo.
|
https://github.com/zeldaret/oot/blob/main/src/overlays/actors/ovl_En_Dy_Extra/z_en_dy_extra.c#L93 Looks like upstream opted to put 0x00 at end of array (causing same behavior) I'll update PR to match upstream code Fixed upstream in zeldaret/oot#1239 |
garrettjoecox
left a comment
There was a problem hiding this comment.
Looks like upstream opted to put 0x00 at end of array (causing same behavior)
I'll update PR to match upstream code
Even better! Looks like you missed a comma but otherwise looks good
null
Build Artifacts