Add sound effects to tunic/boot equips#446
Merged
Kenix3 merged 2 commits intoHarbourMasters:developfrom Jun 6, 2022
Merged
Conversation
NEstelami
reviewed
Jun 6, 2022
NEstelami
approved these changes
Jun 6, 2022
Kenix3
approved these changes
Jun 6, 2022
stratomaster64
pushed a commit
to stratomaster64/Shipwright
that referenced
this pull request
Jun 13, 2022
* Add sound effects to tunic/boot equips * Use enums for assignable equip swaps
th-2021
pushed a commit
to th-2021/Shipwright-cmake
that referenced
this pull request
Jun 19, 2022
* Add sound effects to tunic/boot equips * Use enums for assignable equip swaps
stratomaster64
pushed a commit
to stratomaster64/Shipwright
that referenced
this pull request
Jun 20, 2022
* Add sound effects to tunic/boot equips * Use enums for assignable equip swaps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a minor addendum to @Rozelette's #328, this adds equipment swapping sound effects to the assignable C-button tunics and boots enhancement.
As discussed in the Discord, this is mostly the generic equipment changing sound effect
NA_SE_PL_CHANGE_ARMS, with the only exception being for the Iron Boots, which play the Iron Boots clank sound,NA_SE_PL_WALK_HEAVYBOOTS.Before making this PR, I checked in with Rozelette, who already had plans to make this change but has been busy, who said to go ahead.