Merged
Conversation
…ent LUS except InputViewer, CheckTracker, ItemTracker and Modals.
…aw()` to bypass the ImGui Begin and End, as they're not intended to go in the modern menu.
Contributor
Author
|
Oh, right, the modal system is also excluded. |
Archez
reviewed
Aug 29, 2024
Pepe20129
approved these changes
Sep 10, 2024
ROGsamurai
added a commit
to ROGsamurai/Shipwright
that referenced
this pull request
Sep 10, 2024
Gui window rework (HarbourMasters#4307)
Arrenton
added a commit
to Arrenton/Shipwright
that referenced
this pull request
Sep 13, 2024
Gui window rework (HarbourMasters#4307)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adapts SoH's GuiWindows to the new modern menu system of drawing. Currently excludes Check, Entrance and Item trackers, as well as the Input Viewer, with Draw() overrides to bypass the built-in ImGui Begin and End calls in the normal flow.
Build Artifacts