Skip to content

Fix windows build crash rainbow color issues#425

Merged
louist103 merged 1 commit intoHarbourMasters:developfrom
Baoulettes:patch-2
Jun 2, 2022
Merged

Fix windows build crash rainbow color issues#425
louist103 merged 1 commit intoHarbourMasters:developfrom
Baoulettes:patch-2

Conversation

@Baoulettes
Copy link
Contributor

sizeof issue make it crash on windows.
Thanks Melon :)

sizeof issue make it crash on windows.
Thanks Melon :)
@jbodner09
Copy link
Contributor

Likely will close #424

@jbodner09 jbodner09 mentioned this pull request May 29, 2022
Copy link
Contributor

@briaguya0 briaguya0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and working on my machine. note: this ifixes the issue on linux too

Copy link
Contributor

@getbrainerror getbrainerror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes issue #424 for me aswell.

@louist103
Copy link
Contributor

Tested it locally and it worked. The right way to do this would be to use a std::array and use the built in count but this is fine for now.

@louist103 louist103 merged commit 0bfe2fe into HarbourMasters:develop Jun 2, 2022
stratomaster64 pushed a commit to stratomaster64/Shipwright that referenced this pull request Jun 13, 2022
sizeof issue make it crash on windows.
Thanks Melon :)
stratomaster64 pushed a commit to stratomaster64/Shipwright that referenced this pull request Jun 20, 2022
sizeof issue make it crash on windows.
Thanks Melon :)
@Baoulettes Baoulettes deleted the patch-2 branch July 6, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants