Fix Navi text HUD position#406
Merged
Kenix3 merged 3 commits intoHarbourMasters:developfrom Jun 6, 2022
Merged
Conversation
Member
|
Like poeple are ranting over things like that, It shouldn't be enabled by default as you want the game to come as vanilla by default |
As suggested by Gary
per Kenix
ghost
reviewed
May 23, 2022
|
|
||
| const s16 rCUpBtnX = OTRGetRectDimensionFromRightEdge(R_C_UP_BTN_X+Right_HUD_Margin); | ||
| const s16 rCUPIconX = OTRGetRectDimensionFromRightEdge(R_C_UP_ICON_X+Right_HUD_Margin); | ||
| const s16 rCUPIconX = OTRGetRectDimensionFromRightEdge(R_C_UP_ICON_X+Right_HUD_Margin-!!CVar_GetS32("gNaviTextFix", 0)); |
Contributor
There was a problem hiding this comment.
Makes sure the value is either 0 or 1 and not something else
Kenix3
approved these changes
May 29, 2022
NEstelami
approved these changes
Jun 6, 2022
stratomaster64
pushed a commit
to stratomaster64/Shipwright
that referenced
this pull request
Jun 13, 2022
* Fix Navi text HUD position * Force cvar to return 0 or 1 As suggested by Gary * Disable all bug fixes by default per Kenix
th-2021
pushed a commit
to th-2021/Shipwright-cmake
that referenced
this pull request
Jun 19, 2022
* Fix Navi text HUD position * Force cvar to return 0 or 1 As suggested by Gary * Disable all bug fixes by default per Kenix
stratomaster64
pushed a commit
to stratomaster64/Shipwright
that referenced
this pull request
Jun 20, 2022
* Fix Navi text HUD position * Force cvar to return 0 or 1 As suggested by Gary * Disable all bug fixes by default per Kenix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Navi text that appears on the C-Up button when Navi wants to say something is slightly off-center in the base game. This fix behind a cvar shifts it 1 unit (I assume these units represent 320*240 N64 pixels) to the left, centering it correctly.
Enabled by default because why not.EDIT:
Before:
After:
