Tweak: Reduce save operations when setting entrance discovered#3459
Merged
briaguya0 merged 1 commit intoHarbourMasters:develop-macreadyfrom Nov 29, 2023
Merged
Conversation
briaguya0
approved these changes
Nov 29, 2023
garrettjoecox
approved these changes
Nov 29, 2023
A-Green-Spoon
pushed a commit
to A-Green-Spoon/Shipwright
that referenced
this pull request
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "set entrances discovered" logic would run twice, once for the main entrance and a second time for the "reverse" entrance (to handle saving two-way entrances). The end of the operation would perform a save, which meant that two saves were being performed on the same frame.
This limits the save operation to only happen once for each entrance pair, and also prevents setting the "reverse" entrance when decoupled is on.
This is an effort to reduce the various save operations happening with all the different features in SoH now.
Build Artifacts