Disable Fix Vine Fall when Climb Everything is enabled#3439
Merged
briaguya0 merged 2 commits intoHarbourMasters:develop-macreadyfrom Nov 26, 2023
Merged
Conversation
Contributor
Author
|
Fixes #3369. |
Archez
approved these changes
Nov 24, 2023
Contributor
There was a problem hiding this comment.
My two cents, but since it's an enhancement conflicting with a cheat, I don't think it's worth disabling the fix if the cheat is on (specifically I mean disabling the check box from being toggled).
The user will not notice any difference if the cheat is on or off. Just silently prevent the fix code from running if the cheat is on is fine enough.
Contributor
Author
|
Ah, yeah, that would make sense. |
briaguya0
approved these changes
Nov 25, 2023
A-Green-Spoon
pushed a commit
to A-Green-Spoon/Shipwright
that referenced
this pull request
Nov 30, 2023
…s#3439) * Disable Fix Vine Fall when Climb Everything is enabled. * Remove option disabling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The combo of the two ended up making entering crawlspaces completely impossible. Just Climb Everything made it difficult, but doing a neutral roll in front of it will still let you enable the Enter button. Enabling Fix Vine Fall at the same time would remove even that ability. This adds a check for Climb Everywhere being disabled in order for the Fix Vine Fall code to run.
Build Artifacts