Fix: Skybox crash for Mask Shop#3427
Merged
briaguya0 merged 1 commit intoHarbourMasters:develop-macreadyfrom Nov 24, 2023
Merged
Fix: Skybox crash for Mask Shop#3427briaguya0 merged 1 commit intoHarbourMasters:develop-macreadyfrom
briaguya0 merged 1 commit intoHarbourMasters:develop-macreadyfrom
Conversation
briaguya0
approved these changes
Nov 22, 2023
A-Green-Spoon
pushed a commit
to A-Green-Spoon/Shipwright
that referenced
this pull request
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the investigation for the Mask Shop crash in Entrance rando here #2577, it was found that the skybox rendering garbage data was responsible for the crash. The original skybox code makes it so only 2 faces are rendered for all the shops, but Mask Shop was not included. This is most likely an authentic bug that is not known as the camera is locked in place for shops and on console most likely garbage data is rendered behind the camera.
On SoH however this garbage data will crash the rendered. I've updated the skybox code to include the Mask Shop so that only the 2 expected faces are rendered like the other shops.
I've left a comment documenting the authentic bug and a tag about why it is being fixed by SoH. I am unsure if we would want this behind a CVar. This feels like something that should always apply and not be toggle-able by players. I'd be open to a hidden CVar if we want it, but maybe the comment is sufficient enough.
Build Artifacts