Fix vanilla Deku Nut upgrade bug#333
Merged
Kenix3 merged 2 commits intoHarbourMasters:developfrom May 21, 2022
vaguerant:dekunutgrade
Merged
Fix vanilla Deku Nut upgrade bug#333Kenix3 merged 2 commits intoHarbourMasters:developfrom vaguerant:dekunutgrade
Kenix3 merged 2 commits intoHarbourMasters:developfrom
vaguerant:dekunutgrade
Conversation
Kenix3
approved these changes
May 15, 2022
Rozelette
approved these changes
May 15, 2022
Contributor
Rozelette
left a comment
There was a problem hiding this comment.
LGTM. I checked myself and this flag does not seem to be used anywhere else beside the upgrade
stratomaster64
pushed a commit
to stratomaster64/Shipwright
that referenced
this pull request
Jun 13, 2022
stratomaster64
pushed a commit
to stratomaster64/Shipwright
that referenced
this pull request
Jun 20, 2022
Sirius902
pushed a commit
to Sirius902/Shipwright
that referenced
this pull request
Jul 11, 2022
…smalldevmerge Toir hopefullysmalldevmerge
Malkierian
pushed a commit
to Malkierian/Shipwright
that referenced
this pull request
Nov 20, 2023
* Fixed window pos not restored with OpenGL * Fixed fullscreen in OpenGL (again) Fixes going full screen on the next monitor when the game was on the second half of the screen. * Set Fullscreen state only when call succeeds Also some logging so we hopefully know why it failed. * Consistent behavior for getting monitor SDL always gets the monitor at the middle of the window. Now DXGI does too. Also only resets the position if there is no pixel of the window on any screen. * also get current monitor on resize (DirectX) * Correct typo Co-authored-by: Kenix3 <kenixwhisperwind@gmail.com> --------- Co-authored-by: Kenix3 <kenixwhisperwind@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents the flag from writing if the bugfix cvar is set. I'm pretty confident the original behavior is not relied upon anywhere else as the flag is only otherwise referenced in relation to the Forest Stage, never the Poacher's Saw.
Enabled by default because there are no benefits to the bug.
Fixes #330.