Pass in custom assets to OTRExporter#3328
Merged
Archez merged 2 commits intoHarbourMasters:developfrom Oct 25, 2023
Merged
Conversation
garrettjoecox
approved these changes
Oct 25, 2023
Contributor
garrettjoecox
left a comment
There was a problem hiding this comment.
Confirmed as working end to end on mac
This was referenced Oct 25, 2023
Malkierian
approved these changes
Oct 25, 2023
Contributor
Malkierian
left a comment
There was a problem hiding this comment.
Confirmed working end-to-end on Windows, including with new custom assets.
757f05a to
33214df
Compare
briaguya0
approved these changes
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends #3315 to pass through the custom assets to OTRExporter when generating the soh.otr
Depends on #3315, HarbourMasters/OTRExporter#9 and HarbourMasters/ZAPDTR#14
Build Artifacts