Move SoH custom assets out of OTRExporter#3315
Merged
Archez merged 2 commits intoHarbourMasters:developfrom Oct 25, 2023
Merged
Move SoH custom assets out of OTRExporter#3315Archez merged 2 commits intoHarbourMasters:developfrom
Archez merged 2 commits intoHarbourMasters:developfrom
Conversation
garrettjoecox
approved these changes
Oct 23, 2023
briaguya0
approved these changes
Oct 23, 2023
garrettjoecox
approved these changes
Oct 25, 2023
Contributor
garrettjoecox
left a comment
There was a problem hiding this comment.
Confirmed as working end to end on mac via #3328
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the soh custom assets out of OTRExporter into
soh/assets/custom/so that they can later be fed into OTRExporter externally.I've tried to preserve the git history of the files, hopefully github agrees.
Build Artifacts