Merged
Conversation
Archez
approved these changes
Oct 23, 2023
Contributor
Archez
left a comment
There was a problem hiding this comment.
Looks good! Happy to be one step closer to entrance enums 🚀
Merged
briaguya0
approved these changes
Nov 19, 2023
jamieklassen
pushed a commit
to jamieklassen/Shipwright
that referenced
this pull request
Mar 10, 2024
* transition variables renamed * transition circle * transition wipe * sand storm * remaining sceneloadflag rename * transition trigger macros * transition mode enum * transition type enum * tc set params * creg debug transitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was needed for better entrance docs so ended up giving a foundation for this at least. The enums will need later splitting away from z64.h but will leave that for #3283. I haven't updated scene table since the plan is to update that with the entrance docs anyway. Finally theres a couple transitionTypes which are calculated through using the entrance which havent been updated fully since those were updated with the entrance docs and require macros from that.
Build Artifacts